docs: openmp as default feature (ADR-0006) - #5
Merged
Conversation
- installation guide (EN + zh-hans): describe `openmp` as a default feature of `rstsr-openblas` (since v0.8.0), make the OpenMP-runtime line in the build.rs example unconditional, add the `default-features = false` opt-out and the feature-unification caveat; note that the default features of `rstsr` enable `rstsr-openblas/openmp` whenever its `openblas` feature is on. - ADR-0006: record the decision reversal, the blast radius in both directions (umbrella defaults inherit the link requirement; `default-features = false` umbrella users keep the direct-dep escape), the `OpenBLASConfig::get_parallel` bug fix, and the verification matrix against OpenBLAS 0.3.34 built both ways. Most or all contents generated by AI (model glm-5.3). Co-authored-by: Claude Code <noreply@anthropic.com> Co-authored-by: glm-5.3 <service@zhipuai.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openmpas a default feature ofrstsr-openblas(since v0.8.0) — unconditional OpenMP-runtime link in the build.rs example,default-features = falseopt-out, feature-unification caveat, and howrstsr's default features enable it whenopenblasis on.OpenBLASConfig::get_parallelbug fix, and the verification matrix against OpenBLAS 0.3.34 built both ways.